Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Remove json value from error message (backport #49526) #49534

Closed
wants to merge 1 commit into from
Closed

[BugFix] Remove json value from error message (backport #49526) #49534

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 7, 2024 •
edited by wanpengfei-git
Loading

Why I'm doing:

JsonFunctions::to_json_string may crash when json is invalid.

What I'm doing:

remove json value from error message, and improve it later.

Fixes https://github.com/StarRocks/StarRocksTest/issues/8327

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Documentation PRs only:

If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.

  • Yes, translate English markdown files with GPT
  • Do not translate
This is an automatic backport of pull request #49526 done by [Mergify](https://mergify.com). ## Why I'm doing: JsonFunctions::to_json_string may crash when json is invalid.

What I'm doing:

remove json value from error message, and improve it later.

Fixes https://github.com/StarRocks/StarRocksTest/issues/8327

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@wyb @mergify
[BugFix] Remove json value from error message (#49526)
0770e25 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit e7d9dc0)

# Conflicts:
#	be/src/exec/json_parser.cpp
#	be/test/exec/json_parser_test.cpp
@mergify mergify bot added the conflicts label Aug 7, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 7, 2024

Cherry-pick of e7d9dc0 has failed:

On branch mergify/bp/branch-3.3/pr-49526
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit e7d9dc06da.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/exec/json_parser.cpp
	both modified:   be/test/exec/json_parser_test.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Aug 7, 2024
Merged
26 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 7, 2024 14:15
@mergify mergify bot closed this Aug 7, 2024
auto-merge was automatically disabled August 7, 2024 14:15

Pull request was closed

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Aug 7, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.3/pr-49526 branch August 7, 2024 14:16
@wyb wyb restored the mergify/bp/branch-3.3/pr-49526 branch August 7, 2024 16:12
@wyb wyb reopened this Aug 7, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 7, 2024 16:12
@wyb wyb closed this Aug 8, 2024
auto-merge was automatically disabled August 8, 2024 08:47

Pull request was closed

@wyb wyb deleted the mergify/bp/branch-3.3/pr-49526 branch August 8, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wyb wyb

Labels
automerge conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wyb